lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Mar 2022 14:25:40 +0100 From: Helge Deller <deller@....de> To: Miaoqian Lin <linmq006@...il.com>, Rob Clark <robdclark@...il.com>, Tomi Valkeinen <tomi.valkeinen@...com>, Dave Airlie <airlied@...il.com>, linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] omapfb: Add missing of_node_put() in dvic_probe_of On 3/7/22 13:38, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") > Signed-off-by: Miaoqian Lin <linmq006@...il.com> applied to the fbdev for-next tree. Thanks! Helge > --- > drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > index 2fa436475b40..c8ad3ef42bd3 100644 > --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c > @@ -246,6 +246,7 @@ static int dvic_probe_of(struct platform_device *pdev) > adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0); > if (adapter_node) { > adapter = of_get_i2c_adapter_by_node(adapter_node); > + of_node_put(adapter_node); > if (adapter == NULL) { > dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n"); > omap_dss_put_device(ddata->in);
Powered by blists - more mailing lists