linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pwm: convert atmel pwm to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f039922-b9ea-d3a4-7e60-e5359840d511@microchip.com>
Date:   Mon, 7 Mar 2022 15:24:54 +0000
From:   <Sergiu.Moga@...rochip.com>
To:     <krzysztof.kozlowski@...onical.com>,
        <Claudiu.Beznea@...rochip.com>, <thierry.reding@...il.com>,
        <u.kleine-koenig@...gutronix.de>, <lee.jones@...aro.org>,
        <robh+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-pwm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: convert atmel pwm to json-schema

On 07.03.2022 16:55, Krzysztof Kozlowski wrote:
> On 07/03/2022 15:46, Sergiu Moga wrote:
>> Convert PWM binding for Atmel/Microchip SoCs to Device Tree Schema
>> format.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
>> ---
>>   .../bindings/pwm/atmel,at91sam-pwm.yaml       | 42 +++++++++++++++++++
>>   .../devicetree/bindings/pwm/atmel-pwm.txt     | 35 ----------------
>>   2 files changed, 42 insertions(+), 35 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/pwm/atmel,at91sam-pwm.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-pwm.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/atmel,at91sam-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,at91sam-pwm.yaml
>> new file mode 100644
>> index 000000000000..2d5dd51a6a55
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/atmel,at91sam-pwm.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/atmel,at91sam-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel/Microchip PWM controller
>> +
>> +allOf:
>> +  - $ref: "pwm.yaml#"
> allOf by convention should go between maintaners and properties.
>
Understood.

>> +
>> +maintainers:
>> +  - Claudiu Beznea <claudiu.beznea@...rochip.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - atmel,at91sam9rl-pwm
>> +      - atmel,sama5d3-pwm
>> +      - atmel,sama5d2-pwm
>> +      - microchip,sam9x60-pwm
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  "#pwm-cells":
>> +    const: 3
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: true
> This has to be either additionalProperties:false or
> "unevaluatedProperties:false".
>
>
Indeed, I believe `unevaluatedProperties: false` would be better here. 
Thank you.

>> +
>> +examples:
>> +  - |
>> +        pwm0: pwm@...34000 {
>> +                compatible = "atmel,at91sam9rl-pwm";
>> +                reg = <0xf8034000 0x400>;
>> +                #pwm-cells = <3>;
> Also please change indentation to 2 or 4 spaces (like we use for all DTS
> examples). Four is preferred (only personally).
>
Noted, I will change the indentation to 4 spaces.

> You also need to update the path in MAINTAINERS.
>
Noted.

> Best regards,
> Krzysztof

Thank you for the feedback.

Sergiu