linux-kernel - RE: [PATCH v4 3/3] iio: temperature: ltc2983: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Mar 2022 16:09:01 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: RE: [PATCH v4 3/3] iio: temperature: ltc2983: Make use of device
 properties

> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Friday, March 4, 2022 7:03 PM
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Sa, Nuno <Nuno.Sa@...log.com>; Jonathan Cameron
> <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>
> Subject: [PATCH v4 3/3] iio: temperature: ltc2983: Make use of device
> properties
> 
> [External]
> 
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
> 
> The conversion slightly changes the logic behind property reading for
> the configuration values. Original code allocates just as much memory
> as needed. Then for each separate 32- or 64-bit value it reads it from
> the property and converts to a raw one which will be fed to the sensor.
> In the new code we allocate the amount of memory needed to
> retrieve all
> values at once from the property and then convert them as required.
> 
> Signed-off-by: Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>
> Tested-by: Nuno Sá <nuno.sa@...log.com>
> ---
> v4: added checks for error pointer (Nuno), added Tb tag (Nuno)
> v3: no changes
> 

Hi Andy,

So the patch now just works after applying. Also, removed the
if()...else() in ltc2983_thermocouple_new() and turned it into

if (!IS_ERR_OR_NULL(ref)) {
   ...
}

and applied your fwnode fix and things work....

- Nuno Sá