lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Mar 2022 18:16:59 +0200 From: Jarkko Sakkinen <jarkko@...nel.org> To: Reinette Chatre <reinette.chatre@...el.com> Cc: dave.hansen@...ux.intel.com, tglx@...utronix.de, bp@...en8.de, luto@...nel.org, mingo@...hat.com, linux-sgx@...r.kernel.org, x86@...nel.org, seanjc@...gle.com, kai.huang@...el.com, cathy.zhang@...el.com, cedric.xing@...el.com, haitao.huang@...el.com, mark.shanahan@...el.com, hpa@...or.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH V2 19/32] x86/sgx: Support adding of pages to an initialized enclave On Mon, Feb 07, 2022 at 04:45:41PM -0800, Reinette Chatre wrote: > + encl_page = kzalloc(sizeof(*encl_page), GFP_KERNEL); > + if (!encl_page) > + return VM_FAULT_OOM; > + > + encl_page->desc = addr; > + encl_page->encl = encl; > + > + /* > + * Adding a regular page that is architecturally allowed to only > + * be created with RW permissions. > + * TBD: Interface with user space policy to support max permissions > + * of RWX. > + */ > + prot = PROT_READ | PROT_WRITE; > + encl_page->vm_run_prot_bits = calc_vm_prot_bits(prot, 0); > + encl_page->vm_max_prot_bits = encl_page->vm_run_prot_bits; You should use sgx_encl_page_alloc() here and not reinvent wheel. I wrote a patch that exports it: https://lore.kernel.org/linux-sgx/20220306053211.135762-3-jarkko@kernel.org/T/#u BR, Jarkko
Powered by blists - more mailing lists