linux-kernel - Re: [PATCH] driver: pca953x: avoid error message when resuming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf=vQd5-PGPu3Pcx9bhKSfhdnYDOSOmZKQZQ+bxVkpmYg@mail.gmail.com>
Date:   Mon, 7 Mar 2022 18:22:02 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alifer Moraes <alifer.m@...iscite.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, eran.m@...iscite.com,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        pierluigi.p@...iscite.com,
        FrancescoFerraro <francesco.f@...iscite.com>
Subject: Re: [PATCH] driver: pca953x: avoid error message when resuming

On Mon, Mar 7, 2022 at 5:04 PM Alifer Moraes <alifer.m@...iscite.com> wrote:
>
> From: FrancescoFerraro <francesco.f@...iscite.com>
>
> Avoids the error messages "pca953x 1-0020: failed reading register"
> when resuming from suspend using gpio-key attached to pca9534.

Thanks for your report and fix. My comments below.

First of all, how many of them do you get and why is it a problem?

...

>         const struct pca953x_reg_config *regs;
> +       int is_in_suspend;

Usually we call it is_suspended or so, check existing code by `git
grep ...`. And it can be boolean.

...

>         ret = regmap_bulk_read(chip->regmap, regaddr, value, NBANK(chip));
>         if (ret < 0) {
> -               dev_err(&chip->client->dev, "failed reading register\n");
> +               if (!chip->is_in_suspend)
> +                       dev_err(&chip->client->dev, "failed reading register\n");

Hmm... Maybe we can simply move it to debug level?

>                 return ret;
>         }

...

>         chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
>         if (chip == NULL)
>                 return -ENOMEM;

> +       chip->is_in_suspend = 0;

Redundant change.

-- 
With Best Regards,
Andy Shevchenko