linux-kernel - RE: [PATCH] media: exynos4-is: Fix PM disable depth imbalance in fimc_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000301d83250$5bdc0cf0$139426d0$@samsung.com>
Date:   Mon, 7 Mar 2022 23:52:50 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Miaoqian Lin'" <linmq006@...il.com>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        "'Mauro Carvalho Chehab'" <mchehab@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...onical.com>,
        "'Kyungmin Park'" <kyungmin.park@...sung.com>,
        "'Younghwan Joo'" <yhwan.joo@...sung.com>,
        <linux-media@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] media: exynos4-is:  Fix PM disable depth imbalance in
 fimc_is_probe



>-----Original Message-----
>From: Miaoqian Lin [mailto:linmq006@...il.com]
>Sent: Monday, March 7, 2022 1:22 PM
>To: Sylwester Nawrocki <s.nawrocki@...sung.com>; Mauro Carvalho
>Chehab <mchehab@...nel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski@...onical.com>; Alim Akhtar
><alim.akhtar@...sung.com>; Kyungmin Park
><kyungmin.park@...sung.com>; Younghwan Joo
><yhwan.joo@...sung.com>; linux-media@...r.kernel.org; linux-arm-
>kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Cc: linmq006@...il.com
>Subject: [PATCH] media: exynos4-is: Fix PM disable depth imbalance in
>fimc_is_probe
>
>If probe fails then we need to call pm_runtime_disable() to balance out the
>previous pm_runtime_enable() call.
>
>Fixes: 9a761e436843 ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
>Signed-off-by: Miaoqian Lin <linmq006@...il.com>
>---
Thanks for fixing this

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> drivers/media/platform/exynos4-is/fimc-is.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/media/platform/exynos4-is/fimc-is.c
>b/drivers/media/platform/exynos4-is/fimc-is.c
>index e55e411038f4..81b290dace3a 100644
>--- a/drivers/media/platform/exynos4-is/fimc-is.c
>+++ b/drivers/media/platform/exynos4-is/fimc-is.c
>@@ -830,7 +830,7 @@ static int fimc_is_probe(struct platform_device *pdev)
>
> 	ret = pm_runtime_resume_and_get(dev);
> 	if (ret < 0)
>-		goto err_irq;
>+		goto err_pm_disable;
>
> 	vb2_dma_contig_set_max_seg_size(dev, DMA_BIT_MASK(32));
>
>@@ -864,6 +864,8 @@ static int fimc_is_probe(struct platform_device *pdev)
> 	pm_runtime_put_noidle(dev);
> 	if (!pm_runtime_enabled(dev))
> 		fimc_is_runtime_suspend(dev);
>+err_pm_disable:
>+	pm_runtime_disable(dev);
> err_irq:
> 	free_irq(is->irq, is);
> err_clk:
>--
>2.17.1