[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <178c7536-7b54-5f73-b759-745db4fae2bc@linux.intel.com>
Date: Mon, 7 Mar 2022 15:54:37 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Randy Dunlap <rdunlap@...radead.org>,
Andrew Morton <akpm@...ux-foundation.org>, broonie@...nel.org,
mhocko@...e.cz, sfr@...b.auug.org.au, linux-next@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org
Cc: Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
ALSA Development Mailing List <alsa-devel@...a-project.org>,
Keyon Jie <yang.jie@...ux.intel.com>,
Cezary Rojewski <cezary.rojewski@...el.com>
Subject: Re: mmotm 2022-03-06-20-33 uploaded (sound/soc/intel/boards/)
On 3/7/22 15:12, Randy Dunlap wrote:
>
>
> On 3/6/22 20:34, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2022-03-06-20-33 has been uploaded to
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>
> on x86_64:
>
> ERROR: modpost: "sof_dai_get_bclk" [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
> ERROR: modpost: "sof_dai_get_mclk" [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko] undefined!
>
>
> Full randconfig file is attached.
Thanks Randy for the report. Indeed there's a problem with the
SND_SOC_INTEL_SOF_SSP_AMP_MACH option. It should be conditional on at
least one Intel/SOF platform being selected, as all the other platforms
are already.
The following diff makes the problem go away:
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index 6884ddf9edad..81e012c164b0 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -615,6 +615,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
endif ## SND_SOC_SOF_JASPERLAKE
+if SND_SOC_SOF_HDA_LINK
+
config SND_SOC_INTEL_SOF_SSP_AMP_MACH
tristate "SOF with amplifiers in I2S Mode"
depends on I2C && ACPI
@@ -631,6 +633,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
with RT1308/CS35L41 I2S audio codec.
Say Y if you have such a device.
If unsure select "N".
+endif ## SND_SOC_SOF_HDA_LINK
if SND_SOC_SOF_ELKHARTLAKE
Powered by blists - more mailing lists