linux-kernel - RE: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB8676905699E85011E625BFE68C089@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Mon, 7 Mar 2022 08:19:52 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Alexander Stein <alexander.stein@...tq-group.com>
CC:     "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe
 compatible string

> -----Original Message-----
> From: Alexander Stein <alexander.stein@...tq-group.com>
> Sent: 2022年3月7日 16:03
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: p.zabel@...gutronix.de; l.stach@...gutronix.de; bhelgaas@...gle.com;
> lorenzo.pieralisi@....com; robh@...nel.org; shawnguo@...nel.org;
> linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org;
> linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; kernel@...gutronix.de; dl-linux-imx
> <linux-imx@....com>; Hongxing Zhu <hongxing.zhu@....com>
> Subject: Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe
> compatible string
> 
> Hi Richard,
> 
> thanks for providing a patch supporting PCie on iMX8MP.
> 
> Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu:
> > Add i.MX8MP PCIe compatible string.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index
> > 36c8a06d17a0..252e5b72aee0 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -26,6 +26,7 @@ properties:
> >        - fsl,imx7d-pcie
> >        - fsl,imx8mq-pcie
> >        - fsl,imx8mm-pcie
> > +      - fsl,imx8mp-pcie
> >
> >    reg:
> >      items:
> 
> Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my tree.
> Another patch 7 also doesn't apply cleanly.
> 
Hi Alexander:
Thanks for your quick reply.
In the past days, I had summit some patches, and wait for ack or reviewed tags.
But they might have some conflictions when do the codes merge.
I'm waiting for the ack, and will re-base them in a proper sequence later.

About the #4 patch apply, it's better to pick the following commit, since it had
 Lucas' Reviewed-by tag, and wait for merge.
https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-send-email-hongxing.zhu@nxp.com/

About the #7 patch, I do the changes based on the following patch-set.
https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com/

I would add the dependency patch-set later in the cover-letter later.
Sorry to bring in-conveniency to you.

BTW, If you want to tests PCIe on i.MX8MM EVK board too, the following dts
changes should be cherry-picked from Shawn's git.
b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk board
aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support
cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support

Best Regards
Richard Zhu

> Regards
> Alexander
>