linux-kernel - Re: [PATCH] drm: Drop commas after SoC match table sentinels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af4cffb7-a519-dea1-4b82-f00e9603ce84@baylibre.com>
Date:   Mon, 7 Mar 2022 09:30:27 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Robert Foss <robert.foss@...aro.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm: Drop commas after SoC match table sentinels

On 03/03/2022 13:44, Geert Uytterhoeven wrote:
> It does not make sense to have a comma after a sentinel, as any new
> elements must be added before the sentinel.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/gpu/drm/bridge/nwl-dsi.c  | 2 +-
>   drivers/gpu/drm/meson/meson_drv.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index 5abb5ec3de467458..846df1ee7a2888cb 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -1151,7 +1151,7 @@ MODULE_DEVICE_TABLE(of, nwl_dsi_dt_ids);
>   static const struct soc_device_attribute nwl_dsi_quirks_match[] = {
>   	{ .soc_id = "i.MX8MQ", .revision = "2.0",
>   	  .data = (void *)E11418_HS_MODE_QUIRK },
> -	{ /* sentinel. */ },
> +	{ /* sentinel. */ }
>   };
>   
>   static int nwl_dsi_probe(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 26aeaf0ab86ef932..35eaa669e8fe0c2a 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -167,7 +167,7 @@ static const struct meson_drm_soc_attr meson_drm_soc_attrs[] = {
>   		},
>   		.attrs = (const struct soc_device_attribute []) {
>   			{ .soc_id = "GXL (S805*)", },
> -			{ /* sentinel */ },
> +			{ /* sentinel */ }
>   		}
>   	},
>   };

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>

Tell me if you want me to apply it to drm-misc-next.

Thanks,
Neil