linux-kernel - Re: [PATCH 2/7] serial: 8250_dwlib: RS485 HW full duplex support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <801197e8-7cc4-93fe-d3fe-8cee8c153c97@linux.intel.com>
Date:   Mon, 7 Mar 2022 11:22:35 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Lukas Wunner <lukas@...ner.de>
cc:     linux-serial <linux-serial@...r.kernel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Johan Hovold <johan@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Raymond Tan <raymond.tan@...el.com>
Subject: Re: [PATCH 2/7] serial: 8250_dwlib: RS485 HW full duplex support

On Sun, 6 Mar 2022, Lukas Wunner wrote:

> On Wed, Mar 02, 2022 at 11:56:01AM +0200, Ilpo Järvinen wrote:
> > @@ -110,9 +110,14 @@ static int dw8250_rs485_config(struct uart_port *p, struct serial_rs485 *rs485)
> >  
> >  	if (rs485->flags & SER_RS485_ENABLED) {
> >  		/* Clearing unsupported flags. */
> > -		rs485->flags &= SER_RS485_ENABLED;
> > -
> > -		tcr |= DW_UART_TCR_RS485_EN | DW_UART_TCR_XFER_MODE_DE_OR_RE;
> > +		rs485->flags &= SER_RS485_ENABLED | SER_RS485_RX_DURING_TX;
> > +		tcr |= DW_UART_TCR_RS485_EN;
> > +
> > +		if (rs485->flags & SER_RS485_RX_DURING_TX) {
> > +			tcr |= DW_UART_TCR_XFER_MODE_DE_DURING_RE;
> > +		} else {
> > +			tcr |= DW_UART_TCR_XFER_MODE_DE_OR_RE;
> > +		}
> 
> This patch deletes lines introduced by the preceding patch.
> I'd just squash the two together, I don't see much value in
> introducing full duplex support in a separate patch.

Sure, I can merge them.

-- 
 i.