linux-kernel - Re: [PATCH V2 1/4] cpufreq: amd-pstate: Add more tracepoint for AMD P-State module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiVzssDCijRWZLoK@amd.com>
Date:   Mon, 7 Mar 2022 10:53:38 +0800
From:   Huang Rui <ray.huang@....com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Su, Jinzhou (Joe)" <Jinzhou.Su@....com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "dsmythies@...us.net" <dsmythies@...us.net>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "todd.e.brandt@...ux.intel.com" <todd.e.brandt@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Meng, Li (Jassmine)" <Li.Meng@....com>
Subject: Re: [PATCH V2 1/4] cpufreq: amd-pstate: Add more tracepoint for AMD
 P-State module

On Sat, Mar 05, 2022 at 02:49:51AM +0800, Rafael J. Wysocki wrote:
> On Fri, Mar 4, 2022 at 7:42 AM Huang Rui <ray.huang@....com> wrote:
> >
> > On Fri, Mar 04, 2022 at 02:07:21PM +0800, Su, Jinzhou (Joe) wrote:
> > > Add frequency, mperf, aperf and tsc in the trace. This can be used
> > > to debug and tune the performance of AMD P-state driver.
> > >
> > > Use the time difference between amd_pstate_update to calculate CPU
> > > frequency. There could be sleep in arch_freq_get_on_cpu, so do not
> > > use it here.
> > >
> > > Signed-off-by: Jinzhou Su <Jinzhou.Su@....com>
> > > Co-developed-by: Huang Rui <ray.huang@....com>
> > > Signed-off-by: Huang Rui <ray.huang@....com>
> >
> > Let's remove "Signed-off-by" of me, just leave "Co-developed-by".
> 
> Actually, they both need to be present (the C-d-b clarifies the S-o-b
> meaning), so the above is correct.
> 

OK, I see. Thanks to clarify this.

Best Regards,
Ray