linux-kernel - Re: [PATCH] rtc-mc146818-lib: fix locking in mc146818_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164675751806.57812.5024159758490370034.b4-ty@bootlin.com>
Date:   Tue,  8 Mar 2022 17:38:52 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     linux-kernel@...r.kernel.org,
        Mateusz Jończyk <mat.jonczyk@...pl>,
        linux-rtc@...r.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Thomas Gleixner <tglx@...utronix.de>, stable@...r.kernel.org,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH] rtc-mc146818-lib: fix locking in mc146818_set_time

On Sun, 20 Feb 2022 10:04:03 +0100, Mateusz Jończyk wrote:
> In mc146818_set_time(), CMOS_READ(RTC_CONTROL) was performed without the
> rtc_lock taken, which is required for CMOS accesses. Fix this.
> 
> Nothing in kernel modifies RTC_DM_BINARY, so a separate critical section
> is allowed here.
> 
> 
> [...]

Applied, thanks!

[1/1] rtc-mc146818-lib: fix locking in mc146818_set_time
      commit: c63cdb340a7e0bd3734f9f8e27f082a054b45887

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>