linux-kernel - [ammarfaizi2-block:google/android/kernel/common/android12-5.4 4028/9999] drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse: sparse: symbol 'freelist_waitqueue' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 9 Mar 2022 00:41:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     John Stultz <john.stultz@...aro.org>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:google/android/kernel/common/android12-5.4
 4028/9999] drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse:
 sparse: symbol 'freelist_waitqueue' was not declared. Should it be static?

Hi John,

First bad commit (maybe != root cause):

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.4
head:   8a3679a75730c1babde6bf63e35d227f3305bd90
commit: e3919bfeb0066ab9b5f9765e5610b95672990e64 [4028/9999] ANDROID: dma-buf: system_heap: Add deferred freeing to the system heap
config: x86_64-randconfig-s021-20220307 (https://download.01.org/0day-ci/archive/20220309/202203090021.OvfMJum5-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/ammarfaizi2/linux-block/commit/e3919bfeb0066ab9b5f9765e5610b95672990e64
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-5.4
        git checkout e3919bfeb0066ab9b5f9765e5610b95672990e64
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/dma-buf/heaps/ init/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse: sparse: symbol 'freelist_waitqueue' was not declared. Should it be static?
>> drivers/dma-buf/heaps/deferred-free-helper.c:24:20: sparse: sparse: symbol 'freelist_task' was not declared. Should it be static?

vim +/freelist_waitqueue +23 drivers/dma-buf/heaps/deferred-free-helper.c

bd1639945c30298 John Stultz 2020-12-09  20  
bd1639945c30298 John Stultz 2020-12-09  21  static LIST_HEAD(free_list);
bd1639945c30298 John Stultz 2020-12-09  22  static size_t list_nr_pages;
bd1639945c30298 John Stultz 2020-12-09 @23  wait_queue_head_t freelist_waitqueue;
bd1639945c30298 John Stultz 2020-12-09 @24  struct task_struct *freelist_task;
bd1639945c30298 John Stultz 2020-12-09  25  static DEFINE_SPINLOCK(free_list_lock);
bd1639945c30298 John Stultz 2020-12-09  26  

:::::: The code at line 23 was first introduced by commit
:::::: bd1639945c30298e4bea2b611d6b0cd08d3cdd98 ANDROID: dma-buf: heaps: Add deferred-free-helper library code

:::::: TO: John Stultz <john.stultz@...aro.org>
:::::: CC: John Stultz <john.stultz@...aro.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org