linux-kernel - Re: [PATCH v2 01/25] KVM: x86/mmu: avoid indirect call for get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 18:14:29 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        dmatlack@...gle.com
Subject: Re: [PATCH v2 01/25] KVM: x86/mmu: avoid indirect call for get_cr3

On 3/8/22 17:53, Sean Christopherson wrote:
>> static inline unsigned long kvm_mmu_get_guest_pgd(struct kvm_vcpu *vcpu,
>> 						  struct kvm_mmu *mmu)
>> {
>> 	if (unlikely(vcpu == &vcpu->arch.guest_mmu))
> Well, not that certainly:-)
> 
> 	if (mmu == &vcpu->arch.guest_mmu)
> 
> But you're right, we need to be able to do kvm_read_cr3() for the actual nested_mmu.
> 

Ok, I'll drop this patch for now since the end of the series actually 
introduces the nested_ops already.  And then we can do it for both 
get_guest_pgd and get_pdptr.

Paolo