linux-kernel - Re: [PATCH] ASoC: mxs: Fix error handling in mxs_sgtl5000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164676007157.54315.10226994232050384296.b4-ty@kernel.org>
Date:   Tue, 08 Mar 2022 17:21:11 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        Miaoqian Lin <linmq006@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Shawn Guo <shawnguo@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe

On Tue, 8 Mar 2022 02:01:44 +0000, Miaoqian Lin wrote:
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> For example, when codec_np is NULL, saif_np[0] and saif_np[1]
> are not NULL, it will cause leaks.
> 
> of_node_put() will check if the node pointer is NULL, so we can
> call it directly to release the refcount of regular pointers.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe
      commit: 6ae0a4d8fec551ec581d620f0eb1fe31f755551c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark