linux-kernel - Re: [PATCH] ARM: fix compilation error when BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yie+9J0hyA6k2KvD@dev-arch.thelio-3990X>
Date:   Tue, 8 Mar 2022 13:39:16 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Russell King <rmk+kernel@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled

On Tue, Mar 08, 2022 at 08:18:20PM +0100, Emmanuel Gil Peyrot wrote:
> It was missing a semicolon.
> 
> Fixes build error introduced in
> 25875aa71dfefd1959f07e626c4d285b88b27ac2.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>

Our CI just went red from this as well:

https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090927
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953124502
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090534
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953086304
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953050829

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Linus, would it be possible for you apply this directly?

> ---
>  arch/arm/kernel/spectre.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/spectre.c b/arch/arm/kernel/spectre.c
> index e7fea962d632..0dcefc36fb7a 100644
> --- a/arch/arm/kernel/spectre.c
> +++ b/arch/arm/kernel/spectre.c
> @@ -10,7 +10,7 @@ static bool _unprivileged_ebpf_enabled(void)
>  #ifdef CONFIG_BPF_SYSCALL
>  	return !sysctl_unprivileged_bpf_disabled;
>  #else
> -	return false
> +	return false;
>  #endif
>  }
>  
> -- 
> 2.35.1
> 
>