[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKwvOdkXNGRJkZDd7Cg8jhL9Ex7R+VPYqEEc+VpwDyi9NJKXQQ@mail.gmail.com>
Date: Tue, 8 Mar 2022 15:10:31 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Sandy Huang <hjc@...k-chips.com>, David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev, knaerzche@...il.com,
Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH] drm/rockchip: remove redundant assignment to pointer connector
On Mon, Mar 7, 2022 at 10:17 AM Colin Ian King <colin.i.king@...il.com> wrote:
>
> The pointer connector is being assigned a value that is never read,
> it is being re-assigned in the following statement. The assignment
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored
> to 'connector' is never read [deadcode.DeadStores]
+ Author & reviewer of:
Fixes: 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR
flag to drm_bridge_attach")
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> index 2494b079489d..92a727931a49 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c
> @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
> if (ret)
> goto err_free_encoder;
>
> - connector = &rgb->connector;
> connector = drm_bridge_connector_init(rgb->drm_dev, encoder);
> if (IS_ERR(connector)) {
> DRM_DEV_ERROR(drm_dev->dev,
> --
> 2.35.1
>
>
--
Thanks,
~Nick Desaulniers
Powered by blists - more mailing lists