linux-kernel - Re: linux-next: manual merge of the vhost tree with the block tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220308163640.42bbcdad@canb.auug.org.au>
Date:   Tue, 8 Mar 2022 16:36:40 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Xie Yongji <xieyongji@...edance.com>
Subject: Re: linux-next: manual merge of the vhost tree with the block tree

Hi all,

On Mon, 7 Mar 2022 15:34:39 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
> Today's linux-next merge of the vhost tree got a conflict in:
> 
>   drivers/block/virtio_blk.c
> 
> between commit:
> 
>   24b45e6c2517 ("virtio_blk: simplify refcounting")
> 
> from the block tree and commit:
> 
>   e030759a1ddc ("virtio-blk: Remove BUG_ON() in virtio_queue_rq()")
> 
> from the vhost tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> diff --cc drivers/block/virtio_blk.c
> index 5c636ca7f1a7,8c415be86732..000000000000
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@@ -69,9 -69,13 +69,6 @@@ struct virtio_blk 
>   	/* Process context for config space updates */
>   	struct work_struct config_work;
>   
> - 	/* What host tells us, plus 2 for header & tailer. */
> - 	unsigned int sg_elems;
>  -	/*
>  -	 * Tracks references from block_device_operations open/release and
>  -	 * virtio_driver probe/remove so this object can be freed once no
>  -	 * longer in use.
>  -	 */
>  -	refcount_t refs;
> --
>   	/* Ida index - used to track minor number allocations. */
>   	int index;
>   

This is now a conflict between the block tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped