linux-kernel - Re: [PATCH] udf: remove redundant assignment of variable etype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220308080206.bumkpk2orl7m3cpt@quack3.lan>
Date:   Tue, 8 Mar 2022 09:02:06 +0100
From:   Jan Kara <jack@...e.cz>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jan Kara <jack@...e.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] udf: remove redundant assignment of variable etype

On Mon 07-03-22 15:21:49, Colin Ian King wrote:
> Variable etype is being assigned a value that is never read. The
> variable and assignment are redundant and can be removed.
> 
> Cleans up clang scan build warning:
> fs/udf/super.c:2485:10: warning: Although the value stored to 'etype'
> is used in the enclosing expression, the value is never actually read
> from 'etype' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/udf/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 48871615e489..4042d9739fb7 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -2474,7 +2474,6 @@ static unsigned int udf_count_free_table(struct super_block *sb,
>  	unsigned int accum = 0;
>  	uint32_t elen;
>  	struct kernel_lb_addr eloc;
> -	int8_t etype;
>  	struct extent_position epos;
>  
>  	mutex_lock(&UDF_SB(sb)->s_alloc_mutex);
> @@ -2482,7 +2481,7 @@ static unsigned int udf_count_free_table(struct super_block *sb,
>  	epos.offset = sizeof(struct unallocSpaceEntry);
>  	epos.bh = NULL;
>  
> -	while ((etype = udf_next_aext(table, &epos, &eloc, &elen, 1)) != -1)
> +	while (udf_next_aext(table, &epos, &eloc, &elen, 1) != -1)
>  		accum += (elen >> table->i_sb->s_blocksize_bits);
>  
>  	brelse(epos.bh);
> -- 
> 2.35.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR