linux-kernel - RE: [RESEND PATCH v1] scsi: ufs: exclude UECxx from SFR dump list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 17:10:32 +0900
From:   "Kiwoong Kim" <kwmad.kim@...sung.com>
To:     "'Adrian Hunter'" <adrian.hunter@...el.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <beanhuo@...ron.com>, <cang@...eaurora.org>, <sc.suh@...sung.com>,
        <hy50.seo@...sung.com>, <sh425.lee@...sung.com>,
        <bhoon95.kim@...sung.com>, <vkumar.1997@...sung.com>
Subject: RE: [RESEND PATCH v1] scsi: ufs: exclude UECxx from SFR dump list

> > -	for (pos = 0; pos < len; pos += 4)
> > +	for (pos = 0; pos < len; pos += 4) {
> > +		if (pos >= REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER	&&
> > +		    pos <= REG_UIC_ERROR_CODE_DME)
> 
> Doesn't that need to be 'pos + offset' not just 'pos'
> 

For only ufshcd.c, offset is always zero, so 'offset' doesn't need to be referred to.
But now I think the function is currently public to external modules.

Okay, let me modify this.

Thanks.
Kiwoong Kim