linux-kernel - Re: [PATCH] drm/omap: fix NULL but dereferenced coccicheck error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 10:28:39 +0200
From:   Tomi Valkeinen <tomba@...nel.org>
To:     Wan Jiabing <wanjiabing@...o.com>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...com
Subject: Re: [PATCH] drm/omap: fix NULL but dereferenced coccicheck error

Hi,

On 07/03/2022 11:56, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/gpu/drm/omapdrm/omap_overlay.c:89:22-25: ERROR: r_ovl is NULL
> but dereferenced.
> 
> Here should be ovl->idx rather than r_ovl->idx.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>   drivers/gpu/drm/omapdrm/omap_overlay.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_overlay.c b/drivers/gpu/drm/omapdrm/omap_overlay.c
> index 10730c9b2752..b0bc9ad2ef73 100644
> --- a/drivers/gpu/drm/omapdrm/omap_overlay.c
> +++ b/drivers/gpu/drm/omapdrm/omap_overlay.c
> @@ -86,7 +86,7 @@ int omap_overlay_assign(struct drm_atomic_state *s, struct drm_plane *plane,
>   		r_ovl = omap_plane_find_free_overlay(s->dev, overlay_map,
>   						     caps, fourcc);
>   		if (!r_ovl) {
> -			overlay_map[r_ovl->idx] = NULL;
> +			overlay_map[ovl->idx] = NULL;
>   			*overlay = NULL;
>   			return -ENOMEM;
>   		}

Thanks, I'll pick this up.

  Tomi