linux-kernel - Re: [PATCH v1 1/1] gpio: sim: Declare gpio_sim_hog_config_item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 09:46:43 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpio: sim: Declare gpio_sim_hog_config_item_ops static

On Mon, Mar 7, 2022 at 5:38 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Compiler is not happy:
>
>   warning: symbol 'gpio_sim_hog_config_item_ops' was not declared. Should it be static?
>
> Fixes: cb8c474e79be ("gpio: sim: new testing module")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-sim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 153fe79e1bf3..bb9bb595c1a8 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -1322,7 +1322,7 @@ static void gpio_sim_hog_config_item_release(struct config_item *item)
>         kfree(hog);
>  }
>
> -struct configfs_item_operations gpio_sim_hog_config_item_ops = {
> +static struct configfs_item_operations gpio_sim_hog_config_item_ops = {
>         .release        = gpio_sim_hog_config_item_release,
>  };
>
> --
> 2.34.1
>

Queued for fixes, thanks!

Bart