linux-kernel - Re: [PATCH 03/16] mm/migration: remove unneeded local variable page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a1b2a5e-5b43-b45a-9092-1699cc3fc0c8@huawei.com>
Date:   Tue, 8 Mar 2022 19:29:49 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Alistair Popple <apopple@...dia.com>
CC:     <akpm@...ux-foundation.org>, <mike.kravetz@...cle.com>,
        <shy828301@...il.com>, <willy@...radead.org>,
        <ying.huang@...el.com>, <ziy@...dia.com>, <minchan@...nel.org>,
        <ave.hansen@...ux.intel.com>, <o451686892@...il.com>,
        <almasrymina@...gle.com>, <jhubbard@...dia.com>,
        <rcampbell@...dia.com>, <peterx@...hat.com>,
        <naoya.horiguchi@....com>, <mhocko@...e.com>, <riel@...hat.com>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/16] mm/migration: remove unneeded local variable
 page_lru

On 2022/3/7 18:58, Alistair Popple wrote:
> Miaohe Lin <linmiaohe@...wei.com> writes:
> 
>> We can use page_is_file_lru() directly to help account the isolated
>> pages to simplify the code a bit as same as local variable follflags.
> 
> Looks good, but there are two independent changes here. Even though they are
> small they should probably be split into two patches.

Sounds reasonable. Will try to do this in v2. Thanks.

> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>>  mm/migrate.c | 8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index bc1867a5706c..da5a81052468 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -1609,7 +1609,6 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>>  {
>>  	struct vm_area_struct *vma;
>>  	struct page *page;
>> -	unsigned int follflags;
>>  	int err;
>>
>>  	mmap_read_lock(mm);
>> @@ -1619,8 +1618,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>>  		goto out;
>>
>>  	/* FOLL_DUMP to ignore special (like zero) pages */
>> -	follflags = FOLL_GET | FOLL_DUMP;
>> -	page = follow_page(vma, addr, follflags);
>> +	page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP);
>>
>>  	err = PTR_ERR(page);
>>  	if (IS_ERR(page))
>> @@ -2033,7 +2031,6 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page,
>>
>>  static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
>>  {
>> -	int page_lru;
>>  	int nr_pages = thp_nr_pages(page);
>>  	int order = compound_order(page);
>>
>> @@ -2060,8 +2057,7 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
>>  	if (isolate_lru_page(page))
>>  		return 0;
>>
>> -	page_lru = page_is_file_lru(page);
>> -	mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_lru,
>> +	mod_node_page_state(page_pgdat(page), NR_ISOLATED_ANON + page_is_file_lru(page),
>>  			    nr_pages);
>>
>>  	/*