linux-kernel - Re: [PATCH v3 1/1] device property: Allow error pointer to be passed to fwnode APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YidKbrRq16NV+zNl@smile.fi.intel.com>
Date:   Tue, 8 Mar 2022 14:22:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Nuno Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v3 1/1] device property: Allow error pointer to be passed
 to fwnode APIs

On Tue, Mar 08, 2022 at 01:15:22PM +0200, Sakari Ailus wrote:
> Hi Andy,
> 
> This makes secondary handling quite a big nicer, thanks!

You are welcome!

> A few comments below. Apart from that,
> 
> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Thanks!

...

> On Mon, Mar 07, 2022 at 10:29:49PM +0200, Andy Shevchenko wrote:

> >  #include <linux/acpi.h>
> >  #include <linux/export.h>
> > +#include <linux/fwnode.h>
> 
> Is this intended? linux/property.h already includes linux/fwnode.h.
> 
> >  #include <linux/kernel.h>
> >  #include <linux/of.h>
> >  #include <linux/of_address.h>

Yeah, this is a bit messy in the headers. I will drop the inclusion,
but in the future it would be good to reshuffle property.h, fwnode.h,
and perhaps extract swnode.h.

...

> >  	bool ret;
> >  
> > +	if (IS_ERR_OR_NULL(fwnode))
> > +		return false;

> > +	if (ret == true)
> 
> It's already bool. I'd instead use:
> 
> 	if (ret)

Right, will amend this.

> > +		return ret;

-- 
With Best Regards,
Andy Shevchenko