linux-kernel - RE: [PATCH] input: keyboard: snvs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8412B8A94B2221D5151A135787099@DB9PR04MB8412.eurprd04.prod.outlook.com>
Date:   Tue, 8 Mar 2022 01:43:25 +0000
From:   Jacky Bai <ping.bai@....com>
To:     Alifer Moraes <alifer.m@...iscite.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "eran.m@...iscite.com" <eran.m@...iscite.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Pierluigi Passaro <pierluigi.p@...iscite.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        mcontenti <marco.c@...iscite.com>
Subject: RE: [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only

> Subject: RE: [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only
> 
> > Subject: [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only
> >
> > From: Eran Matityahu <eran.m@...iscite.com>
> >
> > On imx6qdl the interrupt only triggers on the release of the key.
> > Normally, the driver is looking for a change in the state of the key,
> > but since the interrupt triggers on release the key value is always 0, so there
> was no event.
> >
> > Add "key-release-only" boolean dts property to address this issue, and
> > create both key press and key release events when the key is actually released.
> >
> > Signed-off-by: Eran Matityahu <eran.m@...iscite.com>
> > Signed-off-by: mcontenti <marco.c@...iscite.com>
> > Signed-off-by: Alifer Moraes <alifer.m@...iscite.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl.dtsi       |  1 +
> >  drivers/input/keyboard/snvs_pwrkey.c | 21 ++++++++++++++++++++-
> >  2 files changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi
> > b/arch/arm/boot/dts/imx6qdl.dtsi index d27beb47f9a3..9811e6bfd8e5
> > 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -845,6 +845,7 @@ snvs_pwrkey: snvs-powerkey {
> >  					regmap = <&snvs>;
> >  					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> >  					linux,keycode = <KEY_POWER>;
> > +					key-release-only;
> >  					wakeup-source;
> >  					status = "disabled";
> >  				};
> 
> dts changes should be in a separate patch.
> 
> BR
> Jacky Bai
> > diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> > b/drivers/input/keyboard/snvs_pwrkey.c
> > index 65286762b02a..b558e6f898fa 100644
> > --- a/drivers/input/keyboard/snvs_pwrkey.c
> > +++ b/drivers/input/keyboard/snvs_pwrkey.c
> > @@ -66,6 +66,22 @@ static void imx_imx_snvs_check_for_events(struct
> > timer_list *t)
> >  	}
> >  }
> >
> > +static void imx_imx_snvs_check_for_release_events(struct timer_list
> > +*t) {
> > +	struct pwrkey_drv_data *pdata = from_timer(pdata, t, check_timer);
> > +	struct input_dev *input = pdata->input;
> > +	u32 state;
> > +
> > +	/* interrupt only reports release of key so do not wait for state change */
> > +	state = 1;
> > +	input_event(input, EV_KEY, pdata->keycode, state);
> > +	input_sync(input);
> > +
> > +	state = 0;
> > +	input_event(input, EV_KEY, pdata->keycode, state);
> > +	input_sync(input);
> > +}
> > +
> >  static irqreturn_t imx_snvs_pwrkey_interrupt(int irq, void *dev_id)  {
> >  	struct platform_device *pdev = dev_id; @@ -177,7 +193,10 @@ static
> > int imx_snvs_pwrkey_probe(struct platform_device *pdev)
> >  	/* clear the unexpected interrupt before driver ready */
> >  	regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
> >
> > -	timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0);
> > +	if (of_property_read_bool(np, "key-release-only"))

And for older imx6qdl, there is a "emulate-press" property to handle the similar issue.
Why do you need to add a new property to handle the similar thing?

BR
Jacky Bai
> > +		timer_setup(&pdata->check_timer,
> > imx_imx_snvs_check_for_release_events, 0);
> > +	else
> > +		timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events,
> > 0);
> >
> >  	input = devm_input_allocate_device(&pdev->dev);
> >  	if (!input) {
> > --
> > 2.25.1