linux-kernel - Re: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 16:24:59 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
CC:     <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC_LAN966

On 24/02/2022 at 16:29, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The LAN966x Generic Clock Controller is only present on Microchip
> LAN966x SoCs.  Hence add a dependency on SOC_LAN966, to prevent asking
> the user about this driver when configuring a kernel without LAN966x SoC
> support.
> 
> Fixes: 54104ee023333e3b ("clk: lan966x: Add lan966x SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Horatiu, Kavyasree,
We probably need your view on this.

Best regards,
   Nicolas

> ---
>   drivers/clk/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c390e26dadf471f5..1c82a3e1129d4342 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -232,6 +232,7 @@ config COMMON_CLK_GEMINI
> 
>   config COMMON_CLK_LAN966X
>          bool "Generic Clock Controller driver for LAN966X SoC"
> +       depends on SOC_LAN966 || COMPILE_TEST
>          help
>            This driver provides support for Generic Clock Controller(GCK) on
>            LAN966X SoC. GCK generates and supplies clock to various peripherals
> --
> 2.25.1
> 


-- 
Nicolas Ferre