linux-kernel - Re: [PATCH v2] ASoC: tas5805m: fix pdn polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YijVrgZ+Ysv9J/8E@sirena.org.uk>
Date:   Wed, 9 Mar 2022 16:28:30 +0000
From:   Mark Brown <broonie@...nel.org>
To:     John Keeping <john@...anate.com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Daniel Beer <daniel.beer@...rinstitute.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: tas5805m: fix pdn polarity

On Wed, Mar 09, 2022 at 04:19:31PM +0000, John Keeping wrote:
> On Wed, Mar 09, 2022 at 03:56:12PM +0000, Mark Brown wrote:

> > I'm still not seeing the functional change here.  The actual state of
> > the GPIO is identical in both cases, all that's changing is the logical
> > view internally to the kernel.

> Ah, sorry, I'm considering it functional since it changes the device
> tree ABI.

> Used with the same device tree with, say, GPIO_ACTIVE_HIGH the physical
> state of the GPIO will change as a result of this patch and the device
> tree needs to be updated to use GPIO_ACTIVE_LOW.

I think the device tree binding needs to be clarified here to be
explicit about this since there's obviously some room for user confusion
here.  We can probably get away with a change at this point since it's
not hit a release but we do need to try to avoid the situation where any
other implementations use active high polarity for the bindings.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)