linux-kernel - Re: [PATCH] ASoC: wm_adsp: Compressed stream DSP memory structs should be _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220309163047.GJ38351@ediswmail.ad.cirrus.com>
Date:   Wed, 9 Mar 2022 16:30:47 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Simon Trimmer <simont@...nsource.cirrus.com>
CC:     <broonie@...nel.org>, <patches@...nsource.cirrus.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: wm_adsp: Compressed stream DSP memory structs
 should be __packed

On Wed, Mar 09, 2022 at 01:00:17PM +0000, Simon Trimmer wrote:
> The compressed stream code has a bunch of structs that are used to
> represent DSP memory but have not been marked __packed. This isn't
> safe, they could get padded on a 64-bit build.
> 
> Signed-off-by: Simon Trimmer <simont@...nsource.cirrus.com>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles