linux-kernel - Re: [PATCH 02/19] context_tracking: Rename context_tracking_user_enter/exit() to user_enter/exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220309205309.GA68269@lothringen>
Date:   Wed, 9 Mar 2022 21:53:09 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Phil Auld <pauld@...hat.com>,
        Alex Belits <abelits@...vell.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        Neeraj Upadhyay <quic_neeraju@...cinc.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yu Liao <liaoyu15@...wei.com>,
        Boqun Feng <boqun.feng@...il.com>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Uladzislau Rezki <uladzislau.rezki@...y.com>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH 02/19] context_tracking: Rename
 context_tracking_user_enter/exit() to user_enter/exit_callable()

On Sat, Mar 05, 2022 at 02:59:40PM +0100, Peter Zijlstra wrote:
> On Wed, Mar 02, 2022 at 04:47:53PM +0100, Frederic Weisbecker wrote:
> > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> > index ad2a973393a6..83e050675b23 100644
> > --- a/kernel/context_tracking.c
> > +++ b/kernel/context_tracking.c
> > @@ -125,11 +125,16 @@ void context_tracking_enter(enum ctx_state state)
> >  NOKPROBE_SYMBOL(context_tracking_enter);
> >  EXPORT_SYMBOL_GPL(context_tracking_enter);
> >  
> > -void context_tracking_user_enter(void)
> > +/**
> > + * user_enter_callable() - Unfortunate ASM callable version of user_enter() for
> > + * 			   archs that didn't manage to check the context tracking
> > + * 			   static key from low level code.
> > + */
> > +void user_enter_callable(void)
> >  {
> >  	user_enter();
> >  }
> > -NOKPROBE_SYMBOL(context_tracking_user_enter);
> > +NOKPROBE_SYMBOL(user_enter_callable);
> >  
> >  /**
> >   * __ct_user_exit - Inform the context tracking that the CPU is
> > @@ -182,11 +187,16 @@ void context_tracking_exit(enum ctx_state state)
> >  NOKPROBE_SYMBOL(context_tracking_exit);
> >  EXPORT_SYMBOL_GPL(context_tracking_exit);
> >  
> > -void context_tracking_user_exit(void)
> > +/**
> > + * user_exit_callable() - Unfortunate ASM callable version of user_exit() for
> > + * 			  archs that didn't manage to check the context tracking
> > + * 			  static key from low level code.
> > + */
> > +void user_exit_callable(void)
> >  {
> >  	user_exit();
> >  }
> > -NOKPROBE_SYMBOL(context_tracking_user_exit);
> > +NOKPROBE_SYMBOL(user_exit_callable);
> 
> I'm thinking all this wants to be noinstr instead of NOKPROBE_SYMBOL..

Good point, I'll fix that ahead.