linux-kernel - Re: [PATCH] mm: fs: fix lru_cache_disabled race in bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220309140627.eeaa069daa921dbef64f8970@linux-foundation.org>
Date:   Wed, 9 Mar 2022 14:06:27 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Minchan Kim <minchan@...nel.org>
Cc:     linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>,
        Chris Goldsworthy <cgoldswo@...eaurora.org>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        John Dias <joaodias@...gle.com>
Subject: Re: [PATCH] mm: fs: fix lru_cache_disabled race in bh_lru

On Tue,  8 Mar 2022 10:07:09 -0800 Minchan Kim <minchan@...nel.org> wrote:

> Check lru_cache_disabled under bh_lru_lock. Otherwise, it could
> introduce race below and it fails to migrate pages containing
> buffer_head.
> 
>    CPU 0					CPU 1
> 
> bh_lru_install
>                                        lru_cache_disable
>   lru_cache_disabled = false
>                                        atomic_inc(&lru_disable_count);
> 				       invalidate_bh_lrus_cpu of CPU 0
> 				       bh_lru_lock
> 				       __invalidate_bh_lrus
> 				       bh_lru_unlock
>   bh_lru_lock
>   install the bh
>   bh_lru_unlock

What are the user-visible runtime effects of this bug?

Is a cc:stable needed?

Should there be a reported-by?

Thanks.