linux-kernel - Re: [PATCH] docs: proc.rst: fix wrong time unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r17a7lnr.fsf@meer.lwn.net>
Date:   Wed, 09 Mar 2022 16:26:16 -0700
From:   Jonathan Corbet <corbet@....net>
To:     YI <afctgo@...il.com>, trivial@...nel.org
Cc:     YI <afctgo@...il.com>, Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Anton Mitterer <mail@...istoph.anton.mitterer.name>,
        Kalesh Singh <kaleshsingh@...gle.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Colin Cross <ccross@...gle.com>,
        Mike Rapoport <rppt@...nel.org>, Peter Xu <peterx@...hat.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] docs: proc.rst: fix wrong time unit

YI <afctgo@...il.com> writes:

> From: YI <afctgo@...il.com>
>
> Dear Trivial Patch Monkey, 

The trivial patch monkey has gone into retirement, I'm as close as
you're going to get.

> This commit fixes a small documentaion problem reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=194593.
>
> Some fields in the file /proc/$pid/stat represent time.
> Their units are clock_t, not jiffies as stated in the documentation.
> This commit fixes https://bugzilla.kernel.org/show_bug.cgi?id=194593.

We certainly don't need to give the bugzilla URL twice; I'm not
convinced it's needed even once.  The changelog should just say what the
patch does, please.

Also, "clock_t" isn't really a unit type; what are the actual units of
the field?

> Reported-by: hujunjie

This isn't a valid reported-by line

> Signed-off-by: YI <afctgo@...il.com>

...and the signoff need to have your full name, please.

Thanks,

jon