linux-kernel - [ammarfaizi2-block:broonie/sound/for-next 13916/13921] sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Mar 2022 14:09:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: [ammarfaizi2-block:broonie/sound/for-next 13916/13921]
 sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array
 'uvalue->value.integer.value' will always evaluate to 'true'

tree:   https://github.com/ammarfaizi2/linux-block broonie/sound/for-next
head:   0b7daa6bd0a4cab3b0c6f266a8cb1344ce14ef19
commit: 50291652af5269813baa6024eb0e81b5f0bbb451 [13916/13921] ASoC: atmel: mchp-pdmc: add PDMC driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20220309/202203091430.MLY27Bif-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/50291652af5269813baa6024eb0e81b5f0bbb451
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block broonie/sound/for-next
        git checkout 50291652af5269813baa6024eb0e81b5f0bbb451
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/atmel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true' [-Wpointer-bool-conversion]
           bool af = uvalue->value.integer.value ? true : false;
                     ~~~~~~~~~~~~~~~~~~~~~~^~~~~ ~
   1 warning generated.


vim +186 sound/soc/atmel/mchp-pdmc.c

   180	
   181	static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
   182				    struct snd_ctl_elem_value *uvalue)
   183	{
   184		struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
   185		struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
 > 186		bool af = uvalue->value.integer.value ? true : false;
   187	
   188		if (dd->audio_filter_en == af)
   189			return 0;
   190	
   191		dd->audio_filter_en = af;
   192	
   193		return 1;
   194	}
   195	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org