linux-kernel - Re: [PATCH] input: fix variable type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875yontxhu.fsf@baylibre.com>
Date:   Wed, 09 Mar 2022 08:07:25 +0100
From:   Mattijs Korpershoek <mkorpershoek@...libre.com>
To:     cgel.zte@...il.com, dmitry.torokhov@...il.com
Cc:     matthias.bgg@...il.com, lv.ruyi@....com.cn,
        fengping.yu@...iatek.com, m.felsch@...gutronix.de,
        linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] input: fix variable type

On Tue, Mar 08, 2022 at 02:50, cgel.zte@...il.com wrote:

> From: Lv Ruyi (CGEL ZTE) <lv.ruyi@....com.cn>
>
> The irq is defined unsigned int. If the platform_get_irq return a negative
> value, data type cast may result in error.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi (CGEL ZTE) <lv.ruyi@....com.cn>
> ---
>  drivers/input/keyboard/mt6779-keypad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..0dbbddc7f298 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,7 +91,7 @@ static void mt6779_keypad_clk_disable(void *data)
>  static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
>  {
>  	struct mt6779_keypad *keypad;
> -	unsigned int irq;
> +	int irq;
>  	u32 debounce;
>  	bool wakeup;
>  	int error;

Reviewed-by: Mattijs Korpershoek <mkorpershoek@...libre.com>
> -- 
> 2.25.1