linux-kernel - Re: [PATCH for-next 3/9] RDMA/efa: get rid of create_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34dbb6e0-e278-a78c-cddd-b9484b1bf5e3@linux.dev>
Date:   Wed, 9 Mar 2022 09:20:03 +0200
From:   Gal Pressman <gal.pressman@...ux.dev>
To:     Yajun Deng <yajun.deng@...ux.dev>, jgg@...dia.com,
        selvin.xavier@...adcom.com, galpress@...zon.com, sleybo@...zon.com,
        liangwenpeng@...wei.com, liweihang@...wei.com,
        mustafa.ismail@...el.com, shiraz.saleem@...el.com,
        leonro@...dia.com, dennis.dalessandro@...nelisnetworks.com,
        mike.marciniszyn@...nelisnetworks.com, zyjzyj2000@...il.com
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 3/9] RDMA/efa: get rid of create_user_ah

On 08/03/2022 16:37, Yajun Deng wrote:
> There is no create_user_ah in ib_device_ops, remove it.
>
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
>  drivers/infiniband/hw/efa/efa_main.c  | 2 +-
>  drivers/infiniband/hw/efa/efa_verbs.c | 5 +++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c
> index 94b94cca4870..b2f3832cd305 100644
> --- a/drivers/infiniband/hw/efa/efa_main.c
> +++ b/drivers/infiniband/hw/efa/efa_main.c
> @@ -361,7 +361,7 @@ static const struct ib_device_ops efa_dev_ops = {
>  	.alloc_ucontext = efa_alloc_ucontext,
>  	.create_cq = efa_create_cq,
>  	.create_qp = efa_create_qp,
> -	.create_user_ah = efa_create_ah,
> +	.create_ah = efa_create_ah,
>  	.dealloc_pd = efa_dealloc_pd,
>  	.dealloc_ucontext = efa_dealloc_ucontext,
>  	.dereg_mr = efa_dereg_mr,
> diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
> index ecfe70eb5efb..44269eb18780 100644
> --- a/drivers/infiniband/hw/efa/efa_verbs.c
> +++ b/drivers/infiniband/hw/efa/efa_verbs.c
> @@ -1959,6 +1959,11 @@ int efa_create_ah(struct ib_ah *ibah,
>  	struct efa_ah *ah = to_eah(ibah);
>  	int err;
>  
> +	if (!udata) {
> +		err = -EOPNOTSUPP;
> +		goto err_out;
> +	}
> +

This part is not needed, kverbs flows are blocked for EFA.

Thanks