linux-kernel - Re: [PATCH v2 08/25] KVM: x86/mmu: split cpu_mode from mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175b89f0-14a6-2309-041f-69314d9f191a@redhat.com>
Date:   Wed, 9 Mar 2022 10:58:54 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        dmatlack@...gle.com
Subject: Re: [PATCH v2 08/25] KVM: x86/mmu: split cpu_mode from mmu_role

On 3/8/22 19:55, Sean Christopherson wrote:
>>   static void shadow_mmu_init_context(struct kvm_vcpu *vcpu, struct kvm_mmu *context,
>> -				    const struct kvm_mmu_role_regs *regs,
>> -				    union kvm_mmu_role new_role)
>> +				    union kvm_mmu_role cpu_mode,
> Can you give all helpers this treatment (rename "role" => "cpu_mode")?  I got
> tripped up a few times reading patches because the ones where it wasn't necessary,
> i.e. where there's only a single kvm_mmu_role paramenter, were left as-is.
> 
> I think kvm_calc_shadow_npt_root_page_role() and kvm_calc_shadow_mmu_root_page_role()
> are the only offenders.

These take struct kvm_mmu_role_regs; they *return* union kvm_mmu_role 
but that is changed later in the series to the base part only.

Paolo