linux-kernel - Re: [PATCH v2 24/25] KVM: x86/mmu: initialize constant-value fields just once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d4cf6ad-a374-51ef-5879-967de1c09cc6@redhat.com>
Date:   Wed, 9 Mar 2022 11:34:10 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        dmatlack@...gle.com
Subject: Re: [PATCH v2 24/25] KVM: x86/mmu: initialize constant-value fields
 just once

On 3/8/22 21:58, Sean Christopherson wrote:
> Using nested_ops is clever, but IMO unnecessary, especially since we can go even
> further by adding a nEPT specific hook to initialize its constant shadow paging
> stuff.
> 
> Here's what I had written spliced in with your code.  Compile tested only for
> this version.

I'll do something in between, keeping the nested_ops but with three 
functions to initialize the various kvm_mmu structs.

Paolo