linux-kernel - Re: [PATCH RESEND v2 0/5] memop selftest for storage key checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fce5827-c022-c285-0786-9e0c68bd145c@linux.ibm.com>
Date:   Wed, 9 Mar 2022 11:43:23 +0100
From:   Janis Schoetterl-Glausch <scgl@...ux.ibm.com>
To:     Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     Thomas Huth <thuth@...hat.com>,
        David Hildenbrand <david@...hat.com>, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v2 0/5] memop selftest for storage key checking

On 3/9/22 10:05, Christian Borntraeger wrote:
> Am 08.03.22 um 13:58 schrieb Janis Schoetterl-Glausch:
>> Refactor memop selftest and add tests.
>> Add storage key tests, both for success as well as failure cases.
>> Similarly, test both vcpu and vm ioctls.
>>
>> v1 -> v2
>>   * restructure commits
>>   * get rid of test_* wrapper functions that hid vm.vm
>>   * minor changes
>>
>> v0 -> v2
>>   * complete rewrite
>>
>> v1: https://lore.kernel.org/kvm/20220217145336.1794778-1-scgl@linux.ibm.com/
>> v0: https://lore.kernel.org/kvm/20220211182215.2730017-11-scgl@linux.ibm.com/
>>
>> Janis Schoetterl-Glausch (5):
>>    KVM: s390: selftests: Split memop tests
>>    KVM: s390: selftests: Add macro as abstraction for MEM_OP
>>    KVM: s390: selftests: Add named stages for memop test
>>    KVM: s390: selftests: Add more copy memop tests
>>    KVM: s390: selftests: Add error memop tests
>>
>>   tools/testing/selftests/kvm/s390x/memop.c | 735 ++++++++++++++++++----
>>   1 file changed, 617 insertions(+), 118 deletions(-)
>>
>>
>> base-commit: ee6a569d3bf64c9676eee3eecb861fb01cc11311
> 
> applied (with minor whitespace fixes). Will queue for kvms390/next.

Not sure if it's a good idea, but I broke style rules here intentionally:

+	CHECK_N_DO(MOP, t.vcpu, LOGICAL, READ, mem2, PAGE_SIZE + 2048,
+			GADDR_V(guest_last_page), KEY(2));

in order to emphasize that the arguments are ultimately arguments to MOP.
I did the same in the DEFAULT(_WRITE)?_READ macros, which checkpatch might
not warn about because of the line break escapes.