linux-kernel - Re: [PATCH 5.15 000/256] 5.15.27-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiiWOovHhWzbxOJV@kroah.com>
Date:   Wed, 9 Mar 2022 12:57:46 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Huang Pei <huangpei@...ngson.cn>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, Pavel Machek <pavel@...x.de>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Florian Fainelli <f.fainelli@...il.com>, slade@...dewatkins.com
Subject: Re: [PATCH 5.15 000/256] 5.15.27-rc2 review

On Tue, Mar 08, 2022 at 02:45:50PM -0800, Guenter Roeck wrote:
> On 3/8/22 13:05, Greg Kroah-Hartman wrote:
> > On Tue, Mar 08, 2022 at 11:08:10PM +0530, Naresh Kamboju wrote:
> 
> 
> [ ... ]
> 
> > > > 
> > > > Reverting 4778338032b3 ("MIPS: fix local_{add,sub}_return on MIPS64")
> > > > has fixed all the 3 build failures.
> > > 
> > > MIPS: fix local_{add,sub}_return on MIPS64
> > > [ Upstream commit 277c8cb3e8ac199f075bf9576ad286687ed17173 ]
> > > 
> > > Use "daddu/dsubu" for long int on MIPS64 instead of "addu/subu"
> > > 
> > > Fixes: 7232311ef14c ("local_t: mips extension")
> > > Signed-off-by: Huang Pei <huangpei@...ngson.cn>
> > > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > 
> > Ah, I'll queue up the revert for that in the morning, thanks for finding
> > it.  Odd it doesn't trigger the same issue in 5.16.y.
> > 
> 
> If you don't want to revert: the fix needs the following two patches:
> 
> e5b40668e93 ("slip: fix macro redefine warning")
> b81e0c2372e ("block: drop unused includes in <linux/genhd.h>")
> 
> Both are in v5.16, so you won't see the problem there.

Thanks, both now added to the queue.

greg k-h