linux-kernel - Re: [PATCH 8/8] Constify comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Mar 2022 12:21:28 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Hatim Muhammed <hatimmohammed369@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     greg@...ah.com, hsweeten@...ionengravers.com
Subject: Re: [PATCH 8/8] Constify comedi_lrange struct pointer

On 09/03/2022 09:12, Hatim Muhammed wrote:
> From: Hatim Muhammed <hatimmohammed369@...il.com>
> 
> Signed-off-by: Hatim Muhammed <hatimmohammed369@...il.com>
> ---
>   drivers/comedi/drivers/das16.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/das16.c b/drivers/comedi/drivers/das16.c
> index 937a69ce0977..d1eeb5896f2d 100644
> --- a/drivers/comedi/drivers/das16.c
> +++ b/drivers/comedi/drivers/das16.c
> @@ -956,7 +956,7 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
>   
>   	/* get any user-defined input range */
>   	if (pg_type == das16_pg_none && (min || max)) {
> -		struct comedi_lrange *lrange;
> +		const struct comedi_lrange *lrange;
>   		struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */
> @@ -990,7 +990,7 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
>   
>   	/* get any user-defined output range */
>   	if (min || max) {
> -		struct comedi_lrange *lrange;
> +		const struct comedi_lrange *lrange;
>   		struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */

NAK.  I'm pretty sure this will result in new compiler warnings because 
*lrange really isn't const.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-