linux-kernel - Re: [PATCH] platform: goldfish: pipe: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Mar 2022 13:23:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] platform: goldfish: pipe: Use platform_get_irq() to get
 the interrupt

On Wed, Mar 09, 2022 at 12:09:45PM +0000, Lad, Prabhakar wrote:
> Hi Greg,
> 
> I'm not sure how I missed you to add in the to list.
> 
> On Fri, Dec 24, 2021 at 4:13 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> >
> > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> > allocation of IRQ resources in DT core code, this causes an issue
> > when using hierarchical interrupt domains using "interrupts" property
> > in the node as this bypasses the hierarchical setup and messes up the
> > irq chaining.
> >
> > In preparation for removal of static setup of IRQ resource from DT core
> > code use platform_get_irq().
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > Hi,
> >
> > Dropping usage of platform_get_resource() was agreed based on
> > the discussion [0].
> >
> > [0] https://patchwork.kernel.org/project/linux-renesas-soc/
> > patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@...renesas.com/
> >
> > Cheers,
> > Prabhakar
> > ---
> >  drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> >
> Do you want me to resend this patch?

If you want me to apply it, yes.

thanks,

greg k-h