linux-kernel - Re: [PATCH 10/10] Constify comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7ce73c6-8c0b-f447-835f-9e2e6f402f7c@mev.co.uk>
Date:   Wed, 9 Mar 2022 12:24:37 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Hatim Muhammed <hatimmohammed369@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     greg@...ah.com, hsweeten@...ionengravers.com
Subject: Re: [PATCH 10/10] Constify comedi_lrange struct pointers

On 09/03/2022 09:20, Hatim Muhammed wrote:
> From: Hatim Muhammed <hatimmohammed369@...il.com>
> 
> Signed-off-by: Hatim Muhammed <hatimmohammed369@...il.com>
> ---
>   drivers/comedi/drivers/jr3_pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/jr3_pci.c b/drivers/comedi/drivers/jr3_pci.c
> index 951c23fa0369..f2a750a9112c 100644
> --- a/drivers/comedi/drivers/jr3_pci.c
> +++ b/drivers/comedi/drivers/jr3_pci.c
> @@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
>   };
>   
>   union jr3_pci_single_range {
> -	struct comedi_lrange l;
> -	char _reserved[offsetof(struct comedi_lrange, range[1])];
> +	const struct comedi_lrange l;
> +	char _reserved[offsetof(const struct comedi_lrange, range[1])];
>   };
>   
>   enum jr3_pci_poll_state {

NAK. That really should not be const.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-