linux-kernel - Re: [PATCH for-next 9/9] RDMA/rxe: get rid of create_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daee0acc-709d-9523-6ca7-a6777430df7d@linux.dev>
Date:   Wed, 9 Mar 2022 21:48:05 +0800
From:   Yanjun Zhu <yanjun.zhu@...ux.dev>
To:     Yajun Deng <yajun.deng@...ux.dev>, jgg@...dia.com,
        selvin.xavier@...adcom.com, galpress@...zon.com, sleybo@...zon.com,
        liangwenpeng@...wei.com, liweihang@...wei.com,
        mustafa.ismail@...el.com, shiraz.saleem@...el.com,
        leonro@...dia.com, dennis.dalessandro@...nelisnetworks.com,
        mike.marciniszyn@...nelisnetworks.com, zyjzyj2000@...il.com
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 9/9] RDMA/rxe: get rid of create_user_ah



在 2022/3/9 21:43, Yanjun Zhu 写道:
> 在 2022/3/8 22:40, Yajun Deng 写道:
>> There is no create_user_ah in ib_device_ops, remove it.
> In the file include/rdma/ib_verbs.h:
> 
> 2305 struct ib_device_ops {
> ...
> 2431         int (*create_user_ah)(struct ib_ah *ah, struct 
> rdma_ah_init_attr *attr,
> 2432                               struct ib_udata *udata);
> ...
> 
> create_user_ah exists.

I found your patch to remove create_user_ah.
IMO, you should merge the 2 patches as one.

Or after the patch to remove create_user_ah is merged in mainline,
then this patch can be sent out.

As such this will not misguide us.

Zhu Yanjun

> 
> Zhu Yanjun
>>
>> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
>> ---
>>   drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c 
>> b/drivers/infiniband/sw/rxe/rxe_verbs.c
>> index 80df9a8f71a1..fa0cf2554425 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
>> @@ -1053,7 +1053,6 @@ static const struct ib_device_ops rxe_dev_ops = {
>>       .create_cq = rxe_create_cq,
>>       .create_qp = rxe_create_qp,
>>       .create_srq = rxe_create_srq,
>> -    .create_user_ah = rxe_create_ah,
>>       .dealloc_driver = rxe_dealloc,
>>       .dealloc_mw = rxe_dealloc_mw,
>>       .dealloc_pd = rxe_dealloc_pd,
>