linux-kernel - Re: [PATCH v2] media: i2c: rdacm2x: properly set subdev entity function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164683826808.123014.1703937676440784435@Monstersaurus>
Date:   Wed, 09 Mar 2022 15:04:28 +0000
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Rob Herring <robh@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: i2c: rdacm2x: properly set subdev entity function

Quoting Laurentiu Palcu (2022-03-09 11:55:06)
> The subdevice entity function was left unset, which produces a warning
> when probing the device:
> 
> mxc-md bus@...00000:camera: Entity type for entity rdacm20 19-0051 was
> not initialized!
> 
> This patch will set entity function to MEDIA_ENT_F_CAM_SENSOR and leave
> flags unset.
> 
> Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver")
> Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")

Ohh, I've never seen a use case for two fixes tags before.
I don't think this requires two patches to implement the fix though.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
> ---
> Changes in v2:
>         * leave entity flags unset;
> 
> Cheers,
> Laurentiu
> 
>  drivers/media/i2c/rdacm20.c | 2 +-
>  drivers/media/i2c/rdacm21.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index 025a610de893..9c6f66cab564 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -611,7 +611,7 @@ static int rdacm20_probe(struct i2c_client *client)
>                 goto error_free_ctrls;
>  
>         dev->pad.flags = MEDIA_PAD_FL_SOURCE;
> -       dev->sd.entity.flags |= MEDIA_ENT_F_CAM_SENSOR;
> +       dev->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
>         ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
>         if (ret < 0)
>                 goto error_free_ctrls;
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index 12ec5467ed1e..ef31cf5f23ca 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -583,7 +583,7 @@ static int rdacm21_probe(struct i2c_client *client)
>                 goto error_free_ctrls;
>  
>         dev->pad.flags = MEDIA_PAD_FL_SOURCE;
> -       dev->sd.entity.flags |= MEDIA_ENT_F_CAM_SENSOR;
> +       dev->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
>         ret = media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
>         if (ret < 0)
>                 goto error_free_ctrls;
> -- 
> 2.17.1
>