linux-kernel - Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YijHr+kkp2bPE1dA@casper.infradead.org>
Date:   Wed, 9 Mar 2022 15:28:47 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     sxwjean@...com
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
        longman@...hat.com, guro@...com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Xiongwei Song <sxwjean@...il.com>
Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of
 alloc_slab_page()

On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@...com wrote:
> From: Xiongwei Song <sxwjean@...il.com>
> 
> The parameter @s is useless for alloc_slab_page(), let's delete it.

Perhaps we could add a little more information here.

It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg
explicitly").  The need for it was removed in 2020 by 1f3147b49d75
("mm: slub: call account_slab_page() after slab page initialization").

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>