linux-kernel - Re: [PATCH v2] ASoC: tas5805m: fix pdn polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YijOHNT0eqDyoviP@sirena.org.uk>
Date:   Wed, 9 Mar 2022 15:56:12 +0000
From:   Mark Brown <broonie@...nel.org>
To:     John Keeping <john@...anate.com>
Cc:     alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Daniel Beer <daniel.beer@...rinstitute.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: tas5805m: fix pdn polarity

On Wed, Mar 09, 2022 at 01:56:49PM +0000, John Keeping wrote:

> The binding defines the GPIO as "pdn-gpios" so when the GPIO is active
> the expectation is that the power down signal is asserted and this is
> how all other drivers using this GPIO name interpret the value.

> But the tas5805m driver inverts the sense from the normal expectation so
> when the powerdown GPIO is logically asserted the chip is running.

> This is a new driver that is not yet in a released kernel and has no
> in-tree users of the binding so fix the sense of the GPIO so that
> logically asserted means that the device is powered down.

> - Rewrite commit message to make it more obvious that this is a change
>   to the interpretation of the GPIO in the binding

I'm still not seeing the functional change here.  The actual state of
the GPIO is identical in both cases, all that's changing is the logical
view internally to the kernel.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)