linux-kernel - Re: [PATCH v2 1/2] nvmet-tcp: support specifying the congestion-control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 23:13:25 +0800
From:   Mingbao Sun <sunmingbao@....com>
To:     Christoph Hellwig <hch@....de>
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        tyler.sun@...l.com, ping.gan@...l.com, yanxiu.cai@...l.com,
        libin.zhang@...l.com, ao.sun@...l.com
Subject: Re: [PATCH v2 1/2] nvmet-tcp: support specifying the
 congestion-control

On Thu, 10 Mar 2022 15:20:34 +0100
Christoph Hellwig <hch@....de> wrote:

> On Thu, Mar 10, 2022 at 07:06:36PM +0800, Mingbao Sun wrote:
> > I feel it’s not proper to create a sysfs entry for each socket.
> > And for those sockets that do not have the exception of
> > congestion-control, it’s merely a waste of resources.
> > 
> > Also, since these sockets generate and die dynamically, the info
> > exported via fs may even do not have the opportunity to be seen by
> > the user.
> > 
> > Anyway, if you insist that the checking and warning here is not proper,
> > I can remove it.   
> 
> Something that can happen during normal operation is per definition no
> something that should be warned about.

Got.
Will remove this checking and warning in the next version.