linux-kernel - Re: [PATCH] block: aoe: handle device timeouts atomic-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YioZaO21yingv0nD@infradead.org>
Date:   Thu, 10 Mar 2022 07:29:44 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Valentin Kleibel <valentin@...is.at>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Justin Sanders <justin@...aid.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] block: aoe: handle device timeouts atomic-safe

On Thu, Mar 10, 2022 at 04:17:37PM +0100, Valentin Kleibel wrote:
> If an aoe device does not respond to any packet on the network layer within
> aoe_deadsecs, the driver tries to mark the device as down, fail all I/O and
> clean out the queue.

I think the problem is that aoe even tries to queue up request
internally. It really needs to switch to use BLK_MQ_F_BLOCKING and
stop queuing up the requests internall at all.