linux-kernel - Re: [PATCH v4 07/24] EDAC/amd64: Define function to dehash address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yiog0a3FnZvV6oSh@zn.tnic>
Date:   Thu, 10 Mar 2022 17:01:21 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <yazen.ghannam@....com>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 07/24] EDAC/amd64: Define function to dehash address

On Wed, Mar 09, 2022 at 09:50:06PM +0000, Yazen Ghannam wrote:
> But I can do something like you suggest. There will be an unconditional call
> to dehash_addr(). Helper functions will be called for specific interleave
> modes. Otherwise, it'll return 0 if hashing isn't used.

That sounds like proper design to me. A single function which dehashes
an address and that's the only thing it does but it takes care of all
possible cases.

Yap. :-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette