linux-kernel - RE: [PATCH] net: netvsc: remove break after return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 18:06:58 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Saurabh Sengar <ssengar@...ux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: netvsc: remove break after return



> -----Original Message-----
> From: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Sent: Thursday, March 10, 2022 12:32 PM
> To: Saurabh Singh Sengar <ssengar@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>;
> KY Srinivasan <kys@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
> wei.liu@...nel.org; Dexuan Cui <decui@...rosoft.com>; davem@...emloft.net; kuba@...nel.org;
> linux-hyperv@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] net: netvsc: remove break after return
> 
> In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES
> case there is already a 'return' statement which results 'break'
> as dead code
> 
> Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> ---
>  drivers/net/hyperv/netvsc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index e675d10..9442f75 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -1630,7 +1630,6 @@ static int netvsc_process_raw_pkt(struct hv_device *device,
> 
>  	case VM_PKT_DATA_USING_XFER_PAGES:
>  		return netvsc_receive(ndev, net_device, nvchan, desc);
> -		break;
> 
>  	case VM_PKT_DATA_INBAND:

Thanks.
Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>