linux-kernel - Re: [PATCH v2] MIPS: Only use current_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdkjsNhR8DNRCjEVLibHf0j1WS54m-CSEQpm070h3J7_4g@mail.gmail.com>
Date:   Thu, 10 Mar 2022 10:20:51 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     David Laight <David.Laight@...lab.com>,
        Kees Cook <keescook@...omium.org>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Marc Zyngier <maz@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Yanteng Si <siyanteng01@...il.com>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>
Subject: Re: [PATCH v2] MIPS: Only use current_stack_pointer on GCC

On Wed, Mar 9, 2022 at 2:44 PM David Laight <David.Laight@...lab.com> wrote:
>
> From: Kees Cook
> > Sent: 09 March 2022 22:10
> >
> > Unfortunately, Clang did not have support for "sp" as a global register
> > definition, and was crashing after the addition of current_stack_pointer.
> > This has been fixed in Clang 15, but earlier Clang versions need to
>                                ^^ 14

Yeah, with that fixed:
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

Once clang-14 is the minimally supported version, we can go back to
removing the inline asm for everyone.


> > avoid this code, so add a versioned test and revert back to the
> > open-coded asm instances. Fixes Clang build error:
> >
> > fatal error: error in backend: Invalid register name global variable
>
>         David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>


-- 
Thanks,
~Nick Desaulniers